View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0030683||2.x IDE Bugs||Room Editor||Public||2019-04-12 17:12||2019-05-15 09:51|
|Reporter||Scott Dunbar||Assigned To||Alexander Borup|
|Priority||Medium||Severity||B - Major||Reproducibility||100%|
|Target Version||2.2.3||Fixed in Version||2.2.3|
|Summary||0030683: Room Editor: Having a very large number of instances and attempting to delete one will cause a very long delay|
Having a very large number of instances in the room editor ( > 13000) and attempting to delete one instance will cause a very long delay
|Steps To Reproduce||1. Open attached project|
2. Open room0
3. select any instance
4. press delete
5. observe incredibly long delay/permanent hang
|Tags||No tags attached.|
|2.x IDE Found In||188.8.131.523|
|2.x Runtime Found In||184.108.40.2066|
|2.x IDE Verified In||220.127.116.117|
|2.x Runtime Verified In||18.104.22.1681|
test.yyz (870,652 bytes)
I have applied some WD-40 to the room editor's Instance Layer Properties window. Before, it would take ~8400ms on a full rebuild and ~900ms on a pooled rebuild. Now it takes ~7800ms on a full rebuild and ~300ms on a pooled rebuild.
Unfortunately the undo system is a more complicated situation that has a vastly greater impact on the slowdown, as it will handle roughly 300 instances every 5 seconds. For 13,000 instances that's nearly 4 minutes; that's just for the "undo" state - it does it all again for the "redo" state. 8 minutes! To see this in effect, re-order the Instances Layer Properties list.
The new undo system for 2.3 will remedy this.
||Committed a small optimization to the layer contents view.|
Note that a change (at least one) has been committed for 2.2.3, so this does need verifying that the room editor still works.
Have changed the resolution to better reflect a) we have made a change for this release, b) we have a new system coming which will drastically alter and improve this issue, so it's not like we're actually giving up on this one...