View Issue Details

IDProjectCategoryView StatusLast Update
00305922.x IDE BugsUI SkinPublic2019-05-15 14:24
ReporterDanAssigned ToAlexander Borup 
PriorityMediumSeverityB - MajorReproducibility100%
Status ClosedResolutionFixed 
Platform-OSWindows 10OS VersionPro x64
Product Version2.2.2 
Target Version2.2.3Fixed in Version2.2.3 
Summary0030592: UI Skin: Changes to the layouts in the Dark skin for 2.2.2 is exposing many people's custom skins are actually invalid
DescriptionIt is not possible to open the font editor in 2.2.2 when using the current version of the custom skin "GMS2blue". They can create a new font resource in the resource tree, but then the font editor causes GMS2 to go unstable - I get a dialog saying this, but the user seemingly does not (they just see the font editor never opens). Looking through the log, you can see a huge number of "[20:00:05:583(25da)] String not found: LayoutManager_DuplicateLayoutID" each GMS2 startup when using the skin. And then you can see two very similar errors when actually trying to open the font editor:

[11:31:33:982(3da4)] Exception in YoYoStudio.Plugins.CorePlugins.ResourceTree,Void MenuCreate() : System.NullReferenceException: Object reference not set to an instance of an object.
   at YoYoStudio.Plugins.CorePlugins.FontEditor.InitFontEditor(GMFont_Controller _fontController, TabItem _workspaceTab, WorkspaceChainInfo _chainInfo)
   at YoYoStudio.Plugins.CorePlugins.FontEditor.Initialise(ModulePackage _ide)
   at YoYoStudio.Plugins.PluginManager.ActivatePlugin(Plugin _plugin, Type _type, Object[] _parameters)
   at YoYoStudio.Plugins.Command.execute_object(String _command, Object _focus, Object[] paramaters)
   at YoYoStudio.Plugins.Command.Perform(Function _command, String _action, Object[] _parameters)
   at YoYoStudio.Plugins.Command.execute_object(String _command, Object _focus, Object[] paramaters)
   at YoYoStudio.MVC.ResourceHelper.OpenResourceEditor(ControllerBase _resource, TabItem _workspaceTab)
   at YoYoStudio.Plugins.CorePlugins.ResourceTree.CreateResourceDirect(TreeViewNode _parent, eResource _type)
   at WeakDelegate(Object , Object[] )
   at YoYoStudio.Core.Utils.WeakDelegate`1.Invoke(Object[] _args)
[11:31:33:983(3da4)] Fatal Error! 'IDE.OnWeakDelegateException - Object reference not set to an instance of an object.'
[11:31:33:983(3da4)] at YoYoStudio.Plugins.CorePlugins.FontEditor.InitFontEditor(GMFont_Controller _fontController, TabItem _workspaceTab, WorkspaceChainInfo _chainInfo)
   at YoYoStudio.Plugins.CorePlugins.FontEditor.Initialise(ModulePackage _ide)
   at YoYoStudio.Plugins.PluginManager.ActivatePlugin(Plugin _plugin, Type _type, Object[] _parameters)
   at YoYoStudio.Plugins.Command.execute_object(String _command, Object _focus, Object[] paramaters)
   at YoYoStudio.Plugins.Command.Perform(Function _command, String _action, Object[] _parameters)
   at YoYoStudio.Plugins.Command.execute_object(String _command, Object _focus, Object[] paramaters)
   at YoYoStudio.MVC.ResourceHelper.OpenResourceEditor(ControllerBase _resource, TabItem _workspaceTab)
   at YoYoStudio.Plugins.CorePlugins.ResourceTree.CreateResourceDirect(TreeViewNode _parent, eResource _type)
   at WeakDelegate(Object , Object[] )
   at YoYoStudio.Core.Utils.WeakDelegate`1.Invoke(Object[] _args)

One other user saw GMS2 was unable to start up at all when they used their own custom skin or attempted to edit the Dark skin again as they were expecting to work.

Expected: During startup, GMS2 verifies that the skin in use is valid and shows an error that a skin is not compatible if errors are found. It should then set Dark as the default again and allow the IDE to start up.
Steps To Reproduce1. Install the attached skin.
2. Start GMS2 and set the skin as active.
3. Create a new GML project and create a new font.
4. GMS2 goes unstable.
5. See the ui.log for all the above error info.
Repro: 100%
TagsFont
2.x IDE Found In2.2.2.399
2.x Runtime Found In2.2.2.312
2.x IDE Verified In9.2.1.1817
2.x Runtime Verified In9.9.1.1441

Activities

Dan

2019-03-06 10:51

Adminstrator  

FontEditorWontOpen.log (106,686 bytes)

Dan

2019-03-06 11:38

Adminstrator  

GMS2blue.rar (4,113,160 bytes)

Alexander Borup

2019-04-09 11:23

Developer   ~0063597

Easy fix. We only load layouts from the default skin, as these are the only valid layout files. All other layout files are out of date. User plugins will add layouts into the default Dark skin too.