View Issue Details

IDProjectCategoryView StatusLast Update
00291262.x IDE BugsRoom EditorPublic2018-09-28 14:08
ReporterSam CummingAssigned ToCoreTech 
PriorityMediumSeverityC - GeneralReproducibility100%
Status AssignedResolutionOpen 
Product Version2.1.3 
Target VersionFixed in Version 
Summary0029126: Room Editor: Changing Room size will remove tiles from the edges of the room, undo doesn't recover them
DescriptionWhen you change the size of a room to make it smaller, any tiles that you have that now fall outside of the room boundaries are deleted. However, if you press Undo, the room will return to the previous size, but the tiles removed will not be recovered.

Expected: When you press Undo, all instances, tiles and assets that were removed are recovered in their original positions.
Steps To Reproduce1. Open any project.
2. Open a Room, add some assets to it. Make sure the edges of the room have assets.
3. Make the room smaller, observe that assets outside of the boundary are removed.
4. Undo.
5. Observe that the room is correctly resized, observe that assets are not recovered.
TagsIDE, RoomEditor
2.x IDE Found In2.1.3.273
2.x Runtime Found In2.1.3.189
2.x IDE Verified In
2.x Runtime Verified In

Activities

Dan

2018-03-13 09:10

Adminstrator   ~0058132

I would expect that we showed you a "There are resources outside the new room size - these will be lost. Are you sure you want to make the room smaller?" dialog first, regardless. If we don't, add this as a separate bug, please.

Mike Dailly

2018-03-13 09:44

Developer   ~0058143

It should either "undo", or show a warning that it's not-undoable. Can also add the "do not show again" message to the dialog.

Claire Hall

2018-03-22 15:32

Developer   ~0058310

Last edited: 2018-03-23 15:53

View 3 revisions

The undo does happen if you click outside of the textbox and undo there. If you undo within the textbox until it displays the original number and then hit enter this counts as entering a new value for the room undo history which is not the same as undoing.

Could possibly do something where undoing to the point of the last 'stored' value triggers an 'undo' in the containing undo context, would then also need to do something similar for redo. This would be a general case for all mvc bound textboxes not just this instance.